itstool: fix cross, fix python warnings#395150
Merged
uninsane merged 3 commits intoNixOS:stagingfrom Apr 3, 2025
Merged
Conversation
ofborg
bot
added
the
6.topic: cross-compilation
github-actions
bot
added
10.rebuild-darwin: 101-500
bjornfor
reviewed
Apr 1, 2025
SFrijters
force-pushed
the
itstool-cross-staging
branch
from
dadb2ba to
f0a2fe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting #341556 again.
Tested on native
x86_64-linux, also cross-compiled toaarch64-linuxand copied to a Raspberry Pi 4.nix path-info -r ./resultshows onlyaarch64in the closure when cross-compiling.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.